Remove redundant code now that syntax roundtrip is more accurate

apache · Dec 13, 2024 · f58f9bb · f58f9bb
1 parent 464fca3
commit f58f9bb
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 24 deletions.
diff --git a/src/dialect/hive.rs b/src/dialect/hive.rs
@@ -66,9 +66,4 @@ impl Dialect for HiveDialect {
     fn supports_table_sample_before_alias(&self) -> bool {
         true
     }
-
-    /// See Hive <https://cwiki.apache.org/confluence/display/hive/languagemanual+sampling>
-    fn supports_implicit_table_sample_method(&self) -> bool {
-        true
-    }
 }
diff --git a/src/dialect/mod.rs b/src/dialect/mod.rs
@@ -718,16 +718,6 @@ pub trait Dialect: Debug + Any {
     fn supports_table_sample_before_alias(&self) -> bool {
         false
     }
-
-    /// Returns true if this dialect support not specifying a table sample method. For example:
-    ///
-    /// Implicit table sample method: `SELECT * FROM tbl TABLESAMPLE (10)`
-    /// Explicit table sample method: `SELECT * FROM tbl TABLESAMPLE BERNOULLI (10)`
-    ///
-    /// <https://jakewheat.github.io/sql-overview/sql-2016-foundation-grammar.html#sample-clause>
-    fn supports_implicit_table_sample_method(&self) -> bool {
-        false
-    }
 }
 
 /// This represents the operators for which precedence must be defined

diff --git a/tests/sqlparser_common.rs b/tests/sqlparser_common.rs
@@ -12386,16 +12386,13 @@ fn parse_create_table_with_enum_types() {
 
 #[test]
 fn test_table_sample() {
-    let dialects = all_dialects_where(|d| !d.supports_implicit_table_sample_method());
-    dialects.verified_stmt("SELECT * FROM tbl AS t TABLESAMPLE BERNOULLI (50)");
-    dialects.verified_stmt("SELECT * FROM tbl AS t TABLESAMPLE SYSTEM (50)");
-    dialects.verified_stmt("SELECT * FROM tbl AS t TABLESAMPLE SYSTEM (50) REPEATABLE (10)");
-
-    // The only dialect that supports implicit tablesample is Hive and it requires aliase after the table sample
-    let dialects = all_dialects_where(|d| {
-        d.supports_implicit_table_sample_method() && d.supports_table_sample_before_alias()
-    });
+    let dialects = all_dialects_where(|d| d.supports_table_sample_before_alias());
     dialects.verified_stmt("SELECT * FROM tbl TABLESAMPLE (50) AS t");
     dialects.verified_stmt("SELECT * FROM tbl TABLESAMPLE (50 ROWS) AS t");
     dialects.verified_stmt("SELECT * FROM tbl TABLESAMPLE (50 PERCENT) AS t");
+
+    let dialects = all_dialects_where(|d| !d.supports_table_sample_before_alias());
+    dialects.verified_stmt("SELECT * FROM tbl AS t TABLESAMPLE BERNOULLI (50)");
+    dialects.verified_stmt("SELECT * FROM tbl AS t TABLESAMPLE SYSTEM (50)");
+    dialects.verified_stmt("SELECT * FROM tbl AS t TABLESAMPLE SYSTEM (50) REPEATABLE (10)");
 }