Support for BigQuery struct, array and bytes , int64, float64 datatypes
#1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6523097396
💛 - Coveralls |
This builds on top of apache#817 - `STRUCT` literal support via `STRUCT` keyword https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#constructing_a_struct - `STRUCT` and `ARRAY` type declarations https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#declaring_an_array_type https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#declaring_a_struct_type It works around the issue of not being able to parse nested types like `ARRAY<ARRAY<INT>>` due to the right angle bracket ambiguity where the tokenizer chooses the right-shift operator (this affects other dialects like Hive that have similar syntax). When parsing such types, we accept a closing `>` or `>>` and track which variant is in use in order to preserve correctness. Fixes apache#901 Closes apache#817
|
Note there appears to be a similar PR: #966 |
alamb
changed the title
struct, array and bytes datatype
alamb
changed the title
struct, array and bytes datatypestruct, array and bytes datatype
alamb
changed the title
struct, array and bytes datatypestruct, array and bytes , int64, float64 datatypes
alamb
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Thank you very much for this contribution @iffyio 👏 -- it is very impressive both well documented and well tested. I had a few minor comments, but nothing that would prevent merging.
Please let me know if you have time to address the comments this week (I plan to make a release later this week)
| #[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash)] | ||
| #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] | ||
| #[cfg_attr(feature = "visitor", derive(Visit, VisitMut))] | ||
| pub enum ArrayElemTypeDef { |
src/parser/mod.rs
Outdated
| @@ -816,6 +836,10 @@ impl<'a> Parser<'a> { | |||
| Keyword::MATCH if dialect_of!(self is MySqlDialect | GenericDialect) => { | |||
| self.parse_match_against() | |||
| } | |||
| Keyword::STRUCT if dialect_of!(self is BigQueryDialect) => { | |||
There was a problem hiding this comment.
Would it be possible to also support this syntax in the Generic dialect? Rationale is explained in https://github.com/sqlparser-rs/sqlparser-rs#new-syntax
Suggested change
| Keyword::STRUCT if dialect_of!(self is BigQueryDialect) => { | |
| Keyword::STRUCT if dialect_of!(self is BigQueryDialect | GenericDialect) => { |
src/parser/mod.rs
Outdated
| /// expr [AS name] | ||
| /// ``` | ||
| /// [1]: https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#constructing_a_struct | ||
| pub fn parse_struct_field_expr(&mut self, typed_syntax: bool) -> Result<Expr, ParserError> { |
| Ok(Expr::Struct { values, fields }) | ||
| } | ||
|
|
||
| /// Parse an expression value for a bigquery struct [1] |
There was a problem hiding this comment.
Can you also add a note to the documentation about the meaning of the typed_syntax parameter?
There was a problem hiding this comment.
Updated the description to cover the parameter
|
Thanks again @iffyio |
serprex
pushed a commit
to serprex/sqlparser-rs
that referenced
this pull request
Nov 6, 2023
lustefaniak
pushed a commit
to getsynq/sqlparser-rs
that referenced
this pull request
Dec 21, 2023
…4` datatypes (apache#1003) # Conflicts: # src/ast/mod.rs # src/parser/mod.rs # tests/sqlparser_common.rs # tests/sqlparser_snowflake.rs
lustefaniak
pushed a commit
to getsynq/sqlparser-rs
that referenced
this pull request
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #817
STRUCTliteral support viaSTRUCTkeyword https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#constructing_a_structSTRUCTandARRAYtype declarations https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#declaring_an_array_type https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#declaring_a_struct_typeIt works around the issue of not being able to parse nested types like
ARRAY<ARRAY<INT>>due to the right angle bracket ambiguity where the tokenizer chooses the right-shift operator (this affects other dialects like Hive that have similar syntax). When parsing such types, we accept a closing>or>>and track which variant is in use in order to preserve correctness.Fixes #901
Closes #817