Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SELECT * EXCEPT/REPLACE syntax from ClickHouse #1013

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

lustefaniak
Copy link
Contributor

@lustefaniak lustefaniak commented Oct 20, 2023

Clickhouse supports much more advanced column meta-level operations which I would consider for future PRs:

SELECT * REPLACE(i + 1 AS i) EXCEPT (j) APPLY(sum) from columns_transformers;

[1] https://clickhouse.com/docs/en/sql-reference/statements/select#modifier-combinations

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6586995739

  • 19 of 22 (86.36%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 87.361%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser/mod.rs 13 16 81.25%
Totals Coverage Status
Change from base Build 6435373786: 0.007%
Covered Lines: 16789
Relevant Lines: 19218

💛 - Coveralls

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you @lustefaniak

@alamb alamb changed the title clickhouse: SELECT * EXCEPT/REPLACE support Support SELECT * EXCEPT/REPLACE syntax from ClickHouse Oct 23, 2023
@alamb alamb merged commit e857a45 into apache:main Oct 23, 2023
10 checks passed
serprex pushed a commit to serprex/sqlparser-rs that referenced this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants