Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snowflake/generic: position can be the name of a column #1014

Closed
wants to merge 1 commit into from
Closed

snowflake/generic: position can be the name of a column #1014

wants to merge 1 commit into from

Conversation

lustefaniak
Copy link
Contributor

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6587273143

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 87.356%
Totals Coverage Status
Change from base Build 6435373786: 0.002%
Covered Lines: 16781
Relevant Lines: 19210
💛 - Coveralls

alamb
alamb approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @lustefaniak

@alamb alamb mentioned this pull request Oct 23, 2023
Merged
@alamb
Copy link
Contributor

alamb commented Oct 23, 2023

I fixed the merge conflict and made a new PR (as I can't push the fix upstream to this branch) #1022

Thanks again @lustefaniak

@alamb alamb closed this in #1022 Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovasoa lovasoa lovasoa approved these changes

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lustefaniak @coveralls @alamb @lovasoa