Add docstrings for Dialects, update README
#1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
DialectsDialects, update README
|
@Dandandan / @andygrove if you have time to review this PR I would appreciate it |
|
cc @lovasoa for your thoughts |
Pull Request Test Coverage Report for Build 6591947055
💛 - Coveralls |
andygrove
reviewed
Oct 20, 2023
| ### New Syntax | ||
|
|
||
| The most commonly accepted PRs add support for or fix a bug in a feature in the | ||
| SQL standard, or a a popular RDBMS, such as Microsoft SQL | ||
| Server or PostgreSQL, will likely be accepted after a brief |
There was a problem hiding this comment.
Suggested change
| Server or PostgreSQL, will likely be accepted after a brief | |
| Server or PostgreSQL, and will likely be accepted after a brief |
andygrove
reviewed
Oct 20, 2023
andygrove
approved these changes
Oct 20, 2023
|
Thank you @andygrove and @lovasoa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to point out that dialect specific syntax should be supported for both
GenericDialectand the specificDialectI also took the time to update the doc strings and the main README