Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support date 'key' when using semi structured data #1023

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

yuval-illumex
Copy link
Contributor

Add support to the following query:

SELECT JSON_DATA:date::date as date
FROM t1

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6624172714

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.359%

Totals Coverage Status
Change from base Build 6619579638: 0.0%
Covered Lines: 16945
Relevant Lines: 19397

💛 - Coveralls

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yuval-illumex -- can you please add a test for this feature (so it doesn't get accidentally broken in some future refactor)?

@alamb alamb changed the title add support in date 'key' when using semi structured data Support date 'key' when using semi structured data Oct 24, 2023
@yuval-illumex
Copy link
Contributor Author

Thanks @alamb , Added test just like the other keywords

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yuval-illumex !

@alamb alamb merged commit 7993384 into apache:main Oct 24, 2023
10 checks passed
serprex pushed a commit to serprex/sqlparser-rs that referenced this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants