common: Make sure + - * / % binary operators work the same in all dialects #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lustefaniak
force-pushed
the
verify-bin-opts
branch
from
d651059 to
3a04074
Compare
alamb
reviewed
Oct 26, 2023
There was a problem hiding this comment.
Thank you very much @lustefaniak -- I have one question about the changed test, but otherwise looks good to me
I ran the tests locally after merging up from main and they worked great!
lustefaniak
force-pushed
the
verify-bin-opts
branch
from
3a04074 to
24a2c07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #1009 is merged this will pass.
From what I see in BigQuery docs,
da-sh-esis invalid identifier when used without quotes.https://cloud.google.com/bigquery/docs/reference/standard-sql/lexical#unquoted_identifiers