Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support parsing optional nulls handling for unique constraint #1567

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

mvzink
Copy link
Contributor

@mvzink mvzink commented Nov 28, 2024

No description provided.

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mvzink! Looks good to me just a minor comment on the test

tests/sqlparser_postgres.rs Outdated Show resolved Hide resolved
@mvzink mvzink requested a review from iffyio December 3, 2024 16:51
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @mvzink!
cc @alamb

@alamb
Copy link
Contributor

alamb commented Dec 4, 2024

Looks good to me -- feel free to merge the PRs in yourself @iffyio as well -- I appreciate the heads up, but you should totally feel empowered to merge directly yourself too

@alamb alamb merged commit 6517da6 into apache:main Dec 4, 2024
8 checks passed
@mvzink mvzink deleted the fix-unique-nulls-distinct branch December 12, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants