Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encapsulate CreateFunction #1573

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

philipcristiano
Copy link
Contributor

Extract CreateFunction from Statement enum into it's own struct.

Continue moving structs as part of #1204

Extract CreateFunction from Statement enum into it's own struct.
@philipcristiano philipcristiano force-pushed the statement-create-function branch from b41b077 to 6fbaee4 Compare November 29, 2024 20:22
@philipcristiano philipcristiano marked this pull request as ready for review November 29, 2024 21:36
@philipcristiano philipcristiano marked this pull request as draft November 29, 2024 21:37
@philipcristiano philipcristiano marked this pull request as ready for review November 30, 2024 13:41
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cc @alamb

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @philipcristiano and @iffyio

@alamb alamb merged commit e16b246 into apache:main Dec 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants