Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support arbitrary composite access expressions #1600

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ayman-sigma
Copy link
Contributor

Right now the CompositeAccess expression is limited to support the PostgreSQL syntax like SELECT (on_hand.item).name FROM on_hand WHERE (on_hand.item).price > 9.
This PR generalize it to support arbitrary composite access expressions. CompositeAccess expression is any prefix expression followed by a period then an identifier. The CompositeAccess itself can also be nested.

This change fixes issues with dialects that can access fields from another expression. For example dialects that supports struct literal. Something like SELECT struct(1 as a).a wouldn't work before this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant