Support arbitrary composite access expressions #1600
+96
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the
CompositeAccess
expression is limited to support the PostgreSQL syntax likeSELECT (on_hand.item).name FROM on_hand WHERE (on_hand.item).price > 9
.This PR generalize it to support arbitrary composite access expressions.
CompositeAccess
expression is any prefix expression followed by a period then an identifier. TheCompositeAccess
itself can also be nested.This change fixes issues with dialects that can access fields from another expression. For example dialects that supports
struct
literal. Something likeSELECT struct(1 as a).a
wouldn't work before this PR.