Add support for BigQuery ANY TYPE data type
#1602
Conversation
There was a problem hiding this comment.
Thanks @MartinSahlen! The changes look reasonable to me, left a couple minor comments
src/parser/mod.rs
Outdated
| @@ -8382,6 +8382,10 @@ impl<'a> Parser<'a> { | |||
| Ok(DataType::Tuple(field_defs)) | |||
| } | |||
| Keyword::TRIGGER => Ok(DataType::Trigger), | |||
| Keyword::ANY => { | |||
There was a problem hiding this comment.
| Keyword::ANY => { | |
| Keyword::ANY if self.peek_keyword(Keyword::TYPE) => { |
Thinking we can add this guard to ensure that it doesn't conflict with a custom data type that happens to be called ANY?
There was a problem hiding this comment.
Ah yes that is much more in line with the desired / intended behavior. As the current approach would result in a parsing error should we come across an ANY type I think.
There was a problem hiding this comment.
I tried implementing this change but it seems to break. hmm
There was a problem hiding this comment.
As this is the first time I'm touching the codebase, I needed to understand the general mechanisms. Your change worked in conjunction with let _ = self.parse_keyword(Keyword::TYPE);, which makes intitutive sense after looking at the code in general.
tests/sqlparser_bigquery.rs
Outdated
| // Templated | ||
| concat!( | ||
| "CREATE OR REPLACE TEMPORARY FUNCTION ", | ||
| "my_function(param1 ANY TYPE) ", | ||
| "AS (", | ||
| "(SELECT 1)", | ||
| ")", | ||
| ), |
There was a problem hiding this comment.
Since the functionality itself is the data type, I'm thinking we can use a dedicated test for it? e.g fn test_parse_any_type()? Also can we add a test case to demonstrate the behavior in the other comment what happens in a sql like CREATE TABLE foo (x ANY);
There was a problem hiding this comment.
Good point, I was in fact doing that but reverted to inlining the test with other UDFs. Not being sure what was the preferred pattern but makes sense!
iffyio
changed the title
ANY TYPE data type
Thanks for the review and suggestions! I have now added the suggested changes and improvements, along with two seperate tests
|
Thanks! |
As referenced in #1601 , here is a PR, with a test, that verifies correct parsing of BigQuery User-defined functions using templated SQL parameters (what a mouthful :D).
More docs on the actual feature/functionality in BQ can be found here: https://cloud.google.com/bigquery/docs/user-defined-functions
Thanks in advance for the consideration!
EDIT: This closes #1601