Add support for ClickHouse FORMAT on INSERT
#1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
Jan 5, 2025
bombsimon
force-pushed
the
insert-into-format
branch
from
08fadd1 to
062c2b4
Compare
bombsimon
force-pushed
the
insert-into-format
branch
from
93ca1fb to
8096e8c
Compare
iffyio
reviewed
Jan 10, 2025
There was a problem hiding this comment.
Thanks @bombsimon! looks good to me overall, left some minor comments
If `source` is not `None` we will land in the first if branch so no need to check if it's `None` again.
bombsimon
force-pushed
the
insert-into-format
branch
from
8096e8c to
3845c7f
Compare
|
Sorry, I messed up my rebase and lost some commits and force pushed 🙈 But we'll squash on merge anyway so probably nothing to fix now. |
iffyio
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds supports for the
SETTINGSandFORMATkeywords used for ClickHouse when inserting data with other syntax than SQL. This can happen e.g. when using the ClickHouse CLI tool to pipe input from files or similar.INSERT INTOStatement