Support mysql partition to table selection
#959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunshao90
force-pushed
the
support-mysql-partition-selection
branch
from
f2b7af9 to
d441f7d
Compare
|
@alamb PTAL |
|
Sorry for the delay -- I was away last week. I am looking at this PR now |
alamb
reviewed
Sep 7, 2023
There was a problem hiding this comment.
Thank you for the contribution @chunshao90 -- this is looking pretty close. I left some suggestions for your consideration
src/parser/mod.rs
Outdated
| let partitions = if dialect_of!(self is MySqlDialect) | ||
| && self.parse_keyword(Keyword::PARTITION) | ||
| { | ||
| let mut partitions = self.parse_comma_separated(|p| p.parse_tuple(true, false))?; |
There was a problem hiding this comment.
As written I think this only checks the first partition for having more than one tuple element (what about values after index 0?)
I think if you used parse_expr here this code would be significantly simpler and there would be no need for error checking
Suggested change
| let mut partitions = self.parse_comma_separated(|p| p.parse_tuple(true, false))?; | |
| let mut partitions = self.parse_comma_separated(Parser::parse_expr)?; |
There was a problem hiding this comment.
Returns an error if there are multiple tuples.
chunshao90
force-pushed
the
support-mysql-partition-selection
branch
from
f287cec to
f3f5c9e
Compare
|
@alamb Please review again. |
alamb
approved these changes
Sep 14, 2023
|
I'll clean up the clippy failures |
alamb
changed the title
partition to table selection
|
Thanks again @chunshao90 ! |
serprex
pushed a commit
to serprex/sqlparser-rs
that referenced
this pull request
Nov 6, 2023
Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support mysql partition selection, example:
Refer to https://dev.mysql.com/doc/refman/8.0/en/partitioning-selection.html