Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for parsing the syntax of MySQL UNIQUE KEY. #962

Merged
merged 4 commits into from
Sep 8, 2023

Conversation

artorias1024
Copy link
Contributor

@artorias1024 artorias1024 commented Aug 31, 2023

Fixes #961

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @artorias1024 - I think this code could be simpler (I left a suggestion) but otherwise it looks good to me. Let me know what you think

I apologize for the delay in reviewing -- I was away last week

src/parser/mod.rs Outdated Show resolved Hide resolved
@alamb alamb changed the title feat:Add support for parsing the syntax of MySQL UNIQUE KEY. feat: Add support for parsing the syntax of MySQL UNIQUE KEY. Sep 7, 2023
@artorias1024 artorias1024 requested a review from alamb September 8, 2023 05:31
@alamb
Copy link
Contributor

alamb commented Sep 8, 2023

Thanks @artorias1024 -- I took the liberty of merging main into this branch to get a fix for a logical merge conflict and I also added 137584c to simplify the logic. What do you think?

@artorias1024
Copy link
Contributor Author

artorias1024 commented Sep 8, 2023

Thanks @artorias1024 -- I took the liberty of merging main into this branch to get a fix for a logical merge conflict and I also added 137584c to simplify the logic. What do you think?

Thanks ~ @alamb

@alamb alamb merged commit 0480ee9 into apache:main Sep 8, 2023
10 checks passed
@alamb
Copy link
Contributor

alamb commented Sep 8, 2023

Thanks again @artorias1024

serprex pushed a commit to serprex/sqlparser-rs that referenced this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: SchemaParse(ParserError("Expected a list of columns in parentheses, found: KEY"))
2 participants