parse SQLite pragma statement #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Sep 20, 2023
| @@ -24,6 +24,51 @@ use sqlparser::ast::*; | |||
| use sqlparser::dialect::{GenericDialect, SQLiteDialect}; | |||
| use sqlparser::tokenizer::Token; | |||
|
|
|||
| #[test] | |||
| fn pragma_no_value() { | |||
There was a problem hiding this comment.
Can you please also add a test for the [schema-name '.'] pragma-name variant as well?
like PRAGMA foo.cache_size = 5?
I think it is ok to start with basic syntax support and then we an add more support as follow on PRs, incrementally. This is the model we have used over time to build up the library of sql parsing capability this library supports |
|
I took the liberty of merging this PR up from main and running |
serprex
pushed a commit
to serprex/sqlparser-rs
that referenced
this pull request
Nov 6, 2023
Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for SQLite PRAGMA statement:
PRAGMA cache_size = 10According to the docs this is not all the possible syntax variations. If someone reviews my changes, I could add more before merging.