clickhouse: add support for LIMIT BY #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lustefaniak
force-pushed
the
clickhouse-limit-by
branch
from
cd2478f to
938a9d2
Compare
alamb
reviewed
Oct 2, 2023
src/parser/mod.rs
Outdated
| @@ -5434,6 +5436,13 @@ impl<'a> Parser<'a> { | |||
| } | |||
| } | |||
|
|
|||
| let limit_by = | |||
| if dialect_of!(self is ClickHouseDialect) && self.parse_keyword(Keyword::BY) { | |||
There was a problem hiding this comment.
in general I think we try to have GenericDialect support the union of all sql dialects, if possible. So this might be something like
Suggested change
| if dialect_of!(self is ClickHouseDialect) && self.parse_keyword(Keyword::BY) { | |
| if dialect_of!(self is ClickHouseDialect | GenericDialect) && self.parse_keyword(Keyword::BY) { |
There was a problem hiding this comment.
Right, good to know ;) I added tests testing both ClickhousDialect and GenericDialect
| @@ -336,6 +336,13 @@ fn parse_create_table() { | |||
| ); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn parse_limit_by() { | |||
There was a problem hiding this comment.
Can you also please add a test for the multi-column form (e.g. LIMIT BY asset, class or similar`)?
lustefaniak
force-pushed
the
clickhouse-limit-by
branch
from
938a9d2 to
212ae9d
Compare
alamb
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://clickhouse.com/docs/en/sql-reference/statements/select/limit-by