Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redshift: add support for CREATE VIEW … WITH NO SCHEMA BINDING #979

Merged
merged 1 commit into from
Oct 2, 2023
Merged

redshift: add support for CREATE VIEW … WITH NO SCHEMA BINDING #979

merged 1 commit into from
Oct 2, 2023

Conversation

lustefaniak
Copy link
Contributor

@lustefaniak lustefaniak commented Sep 24, 2023 •
edited
Loading

@lustefaniak lustefaniak force-pushed the redshift-no-schema-binding branch 2 times, most recently from f93a6bb to b0f16fc Compare September 25, 2023 15:49
alamb
alamb previously approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you (again) @lustefaniak for the contribution

src/ast/mod.rs Show resolved Hide resolved
src/ast/mod.rs Outdated Show resolved Hide resolved
src/parser/mod.rs Outdated Show resolved Hide resolved
tests/sqlparser_redshift.rs Outdated Show resolved Hide resolved
@alamb alamb dismissed their stale review October 2, 2023 12:47

Clicked wrong button -- would like to improve naming and comments prior to merging

@lustefaniak lustefaniak force-pushed the redshift-no-schema-binding branch from b0f16fc to 5136592 Compare October 2, 2023 15:57
@lustefaniak lustefaniak force-pushed the redshift-no-schema-binding branch from 5136592 to 1f63820 Compare October 2, 2023 16:13
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6382674643

  • 24 of 28 (85.71%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 87.218%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser/mod.rs 3 7 42.86%
Files with Coverage Reduction New Missed Lines %
src/ast/mod.rs 1 78.78%
Totals Coverage Status
Change from base Build 6382459778: 0.002%
Covered Lines: 16561
Relevant Lines: 18988
💛 - Coveralls

alamb
alamb approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lustefaniak

@alamb alamb merged commit c811e22 into apache:main Oct 2, 2023
10 checks passed
@lustefaniak lustefaniak deleted the redshift-no-schema-binding branch October 2, 2023 18:22
serprex pushed a commit to serprex/sqlparser-rs that referenced this pull request Nov 6, 2023
@lustefaniak @serprex
redshift: add support for CREATE VIEW … WITH NO SCHEMA BINDING (apach…
b4434db 
…e#979)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lustefaniak @coveralls @alamb