snowflake: support for UNPIVOT and a fix for chained PIVOTs #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Oct 2, 2023
| name: ObjectName, | ||
| table_alias: Option<TableAlias>, | ||
| #[cfg_attr(feature = "visitor", visit(with = "visit_table_factor"))] | ||
| table: Box<TableFactor>, |
There was a problem hiding this comment.
I thought about suggesting this field be named relation but calling it table is consistent with other AST nodes (like Merge) so I think this is good
alamb
approved these changes
Oct 2, 2023
lustefaniak
pushed a commit
to getsynq/sqlparser-rs
that referenced
this pull request
Oct 26, 2023
lustefaniak
added a commit
to getsynq/sqlparser-rs
that referenced
this pull request
Oct 26, 2023
…) (#16) Co-authored-by: Joey Hain <[email protected]>
serprex
pushed a commit
to serprex/sqlparser-rs
that referenced
this pull request
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
UNPIVOT, and also makes a change to the AST forPIVOTto represent more cases, such as pivoting a subquery or the result of anotherPIVOT/UNPIVOT(SF allows this, BQ does not). I implemented the latter case here but not the former - planning to do that in a follow-up.