Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ATTACH DATABASE #989

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Conversation

lovasoa
Copy link
Contributor

@lovasoa lovasoa commented Sep 27, 2023

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6328708806

  • 22 of 26 (84.62%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 87.156%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/mod.rs 5 7 71.43%
src/parser/mod.rs 8 10 80.0%
Files with Coverage Reduction New Missed Lines %
src/ast/mod.rs 1 78.67%
Totals Coverage Status
Change from base Build 6265241374: -0.003%
Covered Lines: 16401
Relevant Lines: 18818

💛 - Coveralls

@lovasoa
Copy link
Contributor Author

lovasoa commented Sep 29, 2023

@alamb , can you have a look ? I'd need that for sqlpage.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thank you @lovasoa

@alamb alamb merged commit 495d0a0 into apache:main Oct 2, 2023
@lovasoa lovasoa deleted the attach-database branch October 2, 2023 12:09
@lovasoa
Copy link
Contributor Author

lovasoa commented Oct 2, 2023

Thanks !

serprex pushed a commit to serprex/sqlparser-rs that referenced this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for SQLite's ATTACH DATABASE statements
3 participants