Skip to content

Commit

Permalink
Minor: Add comment explaining why verify benchmark results uses relea…
Browse files Browse the repository at this point in the history
…se mode (#7712)

While looking into #7709 I discovered why this test is run in release mode, and I wanted to leave a note for my future self
  • Loading branch information
alamb authored Oct 2, 2023
1 parent f959127 commit 2ab0c00
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,7 @@ jobs:
- name: Verify that benchmark queries return expected results
run: |
export TPCH_DATA=`realpath datafusion/sqllogictest/test_files/tpch/data`
# use release build for plan verificaton because debug build causes stack overflow
cargo test plan_q --package datafusion-benchmarks --profile release-nonlto --features=ci -- --test-threads=1
INCLUDE_TPCH=true cargo test --test sqllogictests
- name: Verify Working Directory Clean
Expand Down

0 comments on commit 2ab0c00

Please sign in to comment.