tmp

apache · Aug 13, 2024 · 76f5aba · 76f5aba
1 parent 809ddc9
commit 76f5aba
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/datafusion/functions-aggregate-common/src/aggregate/groups_accumulator.rs b/datafusion/functions-aggregate-common/src/aggregate/groups_accumulator.rs
@@ -132,9 +132,7 @@ impl GroupsAccumulatorAdapter {
             let new_accumulators = input_batch_size - self.convert_state_buffer.len();
             for _ in 0..new_accumulators {
                 let accumulator = (self.factory)()?;
-                let state = AccumulatorState::new(accumulator);
-                self.add_allocation(state.size());
-                self.states.push(state);
+                self.convert_state_buffer.push(accumulator);
             }
 
             self.adjust_allocation(

diff --git a/datafusion/sqllogictest/test_files/aggregate_skip_partial.slt b/datafusion/sqllogictest/test_files/aggregate_skip_partial.slt
@@ -117,6 +117,17 @@ GROUP BY 1, 2 ORDER BY 1 LIMIT 5;
 -2117946883 d -2117946883 NULL NULL NULL
 -2098805236 c -2098805236 NULL NULL NULL
 
+query I
+SELECT MEDIAN(c5)
+FROM aggregate_test_100
+GROUP BY c1 ORDER BY c1 LIMIT 5;
+----
+623103518
+41423756
+-382483011
+16122795
+427197269
+
 # Prepare settings to always skip aggregation after couple of batches
 statement ok
 set datafusion.execution.skip_partial_aggregation_probe_rows_threshold = 10;