Skip to content

Commit

Permalink
address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
comphead committed Jul 12, 2024
1 parent 94933ce commit 92d4696
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion datafusion/core/tests/memory_limit/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,7 @@ async fn sort_merge_join_no_spill() {
])
.with_memory_limit(1_000)
.with_config(config)
.with_scenario(Scenario::AccessLogStreaming)
.run()
.await
}
Expand All @@ -196,6 +197,7 @@ async fn sort_merge_join_spill() {
.with_memory_limit(1_000)
.with_config(config)
.with_disk_manager_config(DiskManagerConfig::NewOs)
.with_scenario(Scenario::AccessLogStreaming)
.run()
.await
}
Expand Down Expand Up @@ -445,7 +447,7 @@ impl TestCase {
let table = scenario.table();

let rt_config = RuntimeConfig::new()
// do not allow spilling
// disk manager setting controls the spilling
.with_disk_manager(disk_manager_config)
.with_memory_limit(memory_limit, MEMORY_FRACTION);

Expand Down

0 comments on commit 92d4696

Please sign in to comment.