Implement unparse ScalarVariable to String
#10541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reswqa
commented
May 16, 2024
datafusion/sql/src/unparser/expr.rs
Outdated
| ast::Expr::Identifier(self.new_ident(ids[0].to_string())) | ||
| } else { | ||
| ast::Expr::CompoundIdentifier( | ||
| ids.iter().map(|i| self.new_ident(i.to_string())).collect(), |
There was a problem hiding this comment.
self.new_ident will add quote_style to the ident. I'm not sure if ScalarVariable need this quote or not.
There was a problem hiding this comment.
I don't think it needs the style -- otherwise the unparsed expr is "@var" rather than @var
|
needs a rebase (I've merged a bunch of other unparse PRs). |
|
I took the liberty of merging up from main to resolve the conflicts |
|
@alamb Thanks for the review 🙇 , have updated it to remove the quote style. |
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* Implement unparse `ScalarVariable` to String * remove quote_style --------- Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10518.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?