Remove expr_fn::sum and replace them with function stub #10816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jayzhan211 <[email protected]>
jayzhan211
commented
Jun 7, 2024
| @@ -5334,3 +5334,34 @@ physical_plan | |||
| 03)----AggregateExec: mode=Partial, gby=[], aggr=[first_value(convert_first_last_table.c1) ORDER BY [convert_first_last_table.c2 DESC NULLS FIRST]] | |||
| 04)------RepartitionExec: partitioning=RoundRobinBatch(4), input_partitions=1 | |||
| 05)--------CsvExec: file_groups={1 group: [[WORKSPACE_ROOT/datafusion/core/tests/data/convert_first_last.csv]]}, projection=[c1, c2], output_orderings=[[c1@0 ASC NULLS LAST], [c2@1 DESC]], has_header=true | |||
|
|
|||
| # test building plan with aggreagte sum | |||
There was a problem hiding this comment.
move the corresponding test in datafusion_expr to avoid introducing another stub
Signed-off-by: jayzhan211 <[email protected]>
github-actions
bot
added
logical-expr
Signed-off-by: jayzhan211 <[email protected]>
alamb
reviewed
Jun 7, 2024
| } | ||
|
|
||
| #[derive(Debug)] | ||
| pub struct Sum { |
There was a problem hiding this comment.
Suggested change
| pub struct Sum { | |
| /// Stub `sum` used for optimizer testing | |
| pub struct Sum { |
|
Thank you @jayzhan211 |
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
alamb
reviewed
Jun 7, 2024
There was a problem hiding this comment.
Thank you @jayzhan211 -- this looks great to me
I also updated this PR's description to add some additional rationale
| @@ -168,20 +168,6 @@ pub fn max(expr: Expr) -> Expr { | |||
| )) | |||
| } | |||
|
|
|||
| /// Create an expression to represent the sum() aggregate function | |||
| /// | |||
| /// TODO: Remove this function and use `sum` from `datafusion_functions_aggregate::expr_fn` instead | |||
|
Thanks @alamb |
alamb
approved these changes
Jun 7, 2024
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* introduce stub for test Signed-off-by: jayzhan211 <[email protected]> * fix err msg Signed-off-by: jayzhan211 <[email protected]> * dont compare error msg, ci is not consistent with local Signed-off-by: jayzhan211 <[email protected]> * comment and cli update Signed-off-by: jayzhan211 <[email protected]> * fmt Signed-off-by: jayzhan211 <[email protected]> --------- Signed-off-by: jayzhan211 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #10731
Inspired from #10807 (comment)
Close #10807
Rationale for this change
The reason to add a stub is that as we pull the aggregate functions out of the core and into
datafusion-functions-aggregatethe existing optimizer passes don't depend on datafusion-functions-aggregate.Thus by using stubs we'll keep the optimizer passes decoupled from the built in aggregate functions as much as possible.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?