[Minor]: Remove datafusion-functions-aggregate dependency from physical-expr crate #11158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @mustafasrepo and @jayzhan211 -- we are slowly breaking out this dependency graph |
comphead
pushed a commit
to comphead/arrow-datafusion
that referenced
this pull request
Jul 2, 2024
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
I recognized that we really don't need this dependency. Removing it simplifies the crate dependency graph.
I guess, the requirement for this dependency was historic, and the need became obsolete at some point. However, I appreciate the input from community.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?