remove termtree dependency #11416
Merged
remove termtree dependency #11416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
reviewed
Jul 12, 2024
| ) { | ||
| if let Some(Some(hi)) = self.heap.get(idx) { | ||
| let connector = if idx != 0 { | ||
| if is_tail { |
| @@ -361,9 +385,9 @@ impl<VAL: ValueType> HeapItem<VAL> { | |||
| impl<VAL: ValueType> Debug for HeapItem<VAL> { | |||
| fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result { | |||
| f.write_str("bucket=")?; | |||
| self.map_idx.fmt(f)?; | |||
| Debug::fmt(&self.map_idx, f)?; | |||
There was a problem hiding this comment.
I think so. If it's not changed, the compiler will fail and report fmt being ambiguous
alamb
approved these changes
Jul 12, 2024
|
Thanks again |
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* remove termtree dependency * impl Display for TopKHeap, replace uses of tree_print in tests * use to_string instead of format!
xinlifoobar
pushed a commit
to xinlifoobar/datafusion
that referenced
this pull request
Jul 17, 2024
* remove termtree dependency * impl Display for TopKHeap, replace uses of tree_print in tests * use to_string instead of format!
xinlifoobar
pushed a commit
to xinlifoobar/datafusion
that referenced
this pull request
Jul 18, 2024
* remove termtree dependency * impl Display for TopKHeap, replace uses of tree_print in tests * use to_string instead of format!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11389
Rationale for this change
What changes are included in this PR?
Remove uses of termtree::tree in heap.rs. Directly generate the string instead.
Are these changes tested?
Are there any user-facing changes?