test: check record count and types in parquet window test #12277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korowa
force-pushed
the
parquet-window-test-port
branch
from
036b2c5 to
832c301
Compare
alamb
changed the title
Co-authored-by: Andrew Lamb <[email protected]>
joroKr21
pushed a commit
to coralogix/arrow-datafusion
that referenced
this pull request
Sep 6, 2024
* test: check record count and types in paqruet window test * Review suggestions Co-authored-by: Andrew Lamb <[email protected]> --------- Co-authored-by: Andrew Lamb <[email protected]>
joroKr21
added a commit
to coralogix/arrow-datafusion
that referenced
this pull request
Sep 6, 2024
* Support encoding and decoding UnnestExec * test: check record count and types in parquet window test (apache#12277) * test: check record count and types in paqruet window test * Review suggestions Co-authored-by: Andrew Lamb <[email protected]> --------- Co-authored-by: Andrew Lamb <[email protected]> --------- Co-authored-by: Eduard Karacharov <[email protected]> Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12185 .
Rationale for this change
The test output is not deterministic due to absence of sorting and bunch of duplicates in input data, and according to the commit history it was not intended to check the output data, but was introduced in order to check that timestamp with timezones are not losing timezones while passing through query pipeline (original PR link).
What changes are included in this PR?
The test behavior is rolled back to the one before porting to sqllogictests -- it now is checking output timestamp type (must contain tz), minimum output timestamp value (suppose it may be important) and total count of output records (not necessary, but may be helpful in case of debugging potential issues with this test).
Test comment also updated as it was suggested in comment to previous PR
Are these changes tested?
Are there any user-facing changes?