Migrate documentation for all math functions from scalar_functions.md to code #12908
Conversation
github-actions
bot
added
documentation
juroberttyb
changed the title
|
|
||
| pub fn get_pow_doc() -> &'static Documentation { | ||
| static DOCUMENTATION: OnceLock<Documentation> = OnceLock::new(); | ||
|
|
There was a problem hiding this comment.
Aliases do not need documentation as the script that generates the docs will insert the alias link automatically
There was a problem hiding this comment.
No problem, this part is removed. Thank you for taking the time to review the PR!
|
Beyond the |
|
PR updated with |
There was a problem hiding this comment.
Thanks @Omega359 and @juroberttyb -- this is a great contribution. I started the CI checks on this PR
I'll plan to merge it in when the CI complete
Thank you!
| @@ -27,534 +27,6 @@ the rest of the documentation. | |||
|
|
|||
| [automatically created from the codebase]: https://github.com/apache/datafusion/issues/12740 | |||
|
|
|||
| ## Math Functions | |||
|
A small cargo fmt and clippy (unused import) fix seems to be required. |
|
No problem. fmt and clippy applied. Thank you both for taking the time to review this PR! |
|
I took the liberty of merging up from main to resolve a conflict (also by pushing a commit I think this PR's CI will run automatically from now on) |
|
Thanks again @juroberttyb and @Omega359 |
|
Thank you both for your time and help! |
Which issue does this PR close?
Closes #12867.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?