Optimize performance of math::cot (~2x faster)
#12910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tai Le Manh <[email protected]>
jonahgao
approved these changes
Oct 15, 2024
|
Wow -- we are just cranking right along here. ❤️ |
findepi
approved these changes
Oct 15, 2024
findepi
reviewed
Oct 15, 2024
| @@ -85,18 +85,16 @@ impl ScalarUDFImpl for CotFunc { | |||
| ///cot SQL function | |||
| fn cot(args: &[ArrayRef]) -> Result<ArrayRef> { | |||
| match args[0].data_type() { | |||
| Float64 => Ok(Arc::new(make_function_scalar_inputs!( | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Using the
unaryfunctions allows faster processing by avoiding branching on nulls.What changes are included in this PR?
unaryAre these changes tested?
Existing testcases.
Are there any user-facing changes?
No.
**BENCHMARK RESULT
