Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused assert_analyzed_plan_ne test helper #13121

Conversation

findepi
Copy link
Member

@findepi findepi commented Oct 26, 2024

Plan textual representation is rich. Testing it's not a particular string is difficult to make robust, that's probably why the helper is unused.

@github-actions github-actions bot added the optimizer Optimizer rules label Oct 26, 2024
Plan textual representation is rich. Testing it's not a particular
string is difficult to make robust, that's probably why the helper is
unused.
@findepi findepi force-pushed the findepi/remove-unused-assert-analyzed-plan-ne-test-helper-461133 branch from f33a973 to 4b6f1c6 Compare October 26, 2024 07:01
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you -- looks great

@alamb alamb merged commit 80ad713 into apache:main Oct 29, 2024
24 checks passed
@findepi findepi deleted the findepi/remove-unused-assert-analyzed-plan-ne-test-helper-461133 branch October 31, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimizer Optimizer rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants