Add basic support for unnest unparsing
#13129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgrebnov
commented
Oct 26, 2024
goldmedal
approved these changes
Oct 27, 2024
| @@ -1340,6 +1341,29 @@ impl Unparser<'_> { | |||
| } | |||
| } | |||
|
|
|||
| /// Converts an UNNEST operation to an AST expression by wrapping it as a function call, | |||
| /// since there is no direct representation for UNNEST in the AST. | |||
There was a problem hiding this comment.
It makes sense to me. On the SQL parser side, it also uses a function call to present UNNEST.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
PR adds basic support for
UNNESTunparsing: Lists/Arrays only (structs support needs some extra work and could be added as incremental improvement).What changes are included in this PR?
PR adds handler for
LogicalPlan::Unnestand updatesreconstruct_select_statementto check if there isUnnestchild so that corresponding columns are correctly unprojected viaunproject_unnest_expr. For examplecolumn("unnest_placeholder([Int64(1),Int64(2),Int64(2),Int64(5),NULL],depth=1)")is transformed intoUNNEST([1, 2, 2, 5, NULL]).Adds
unnest_to_sqlto convert an UNNEST expression to an AST. Since there is no dedicated representation for UNNEST in the AST, the implementation converts the expression to a function call.Are these changes tested?
Added unit tests, tested as part of internal https://github.com/spiceai/spiceai functionality.
Are there any user-facing changes?
Can now unparse plans with unnest (lists/arrays only).