Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs]: added alternative_syntax function for docs #13140

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

jonathanc-n
Copy link
Contributor

Which issue does this PR close?

Closes #13139 .

Rationale for this change

Added alternative syntax argument for doc functions

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added documentation Improvements or additions to documentation logical-expr Logical plan and expressions core Core DataFusion crate functions labels Oct 27, 2024
@jonathanc-n
Copy link
Contributor Author

@Omega359 Does this seem fine?

@Omega359
Copy link
Contributor

❤️ I like this! One minor suggestion: I would suggest changing the style of the alternate syntax to match the .with_syntax_example() style

@Omega359
Copy link
Contributor

❤️ I like this! One minor suggestion: I would suggest changing the style of the alternate syntax to match the .with_syntax_example() style

Actually, on a second look, maybe we should just add the sql to the syntax example. Something for another issue, very minor.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THank you @jonathanc-n and @Omega359

@alamb alamb merged commit a0588cc into apache:main Oct 28, 2024
25 checks passed
@jonathanc-n jonathanc-n deleted the Add-alternative_syntax-function branch November 1, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate documentation Improvements or additions to documentation functions logical-expr Logical plan and expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add alternative_syntax function for docs
3 participants