Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: improve testing docs, mention cargo nextest #13160

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Oct 29, 2024

Which issue does this PR close?

Follow up to #13045

Rationale for this change

Suggested by @Omega359 and @find on #13045 (comment) let's make it more likely someone finds / uses the improvements in #13045

What changes are included in this PR?

  1. Add a mention of cargo nextest
  2. Improve the basic outline a bit too while I was in there

Are these changes tested?

Are there any user-facing changes?

@alamb alamb added the development-process Related to development process of DataFusion label Oct 29, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed development-process Related to development process of DataFusion labels Oct 29, 2024
Copy link
Contributor

@Omega359 Omega359 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @alamb

@alamb
Copy link
Contributor Author

alamb commented Oct 29, 2024

Thank you for your reviews @Omega359 and @comphead

@alamb alamb merged commit d36c229 into apache:main Oct 30, 2024
5 checks passed
@alamb alamb deleted the alamb/improve_test_docs branch October 30, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants