Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: switch completely to generated docs for scalar and aggregate functions #13161

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

Omega359
Copy link
Contributor

Which issue does this PR close?

Partially Closes #12741

Rationale for this change

Improved documentation maintainability

What changes are included in this PR?

Doc related changes only

Are these changes tested?

Yes

Are there any user-facing changes?

(new) docs are removed for scalar and aggregate functions pages

…main .md files for aggregate & scalar function pages.
# Conflicts:
#	docs/source/user-guide/sql/scalar_functions_new.md
@Omega359 Omega359 changed the title switch completely to generated docs for scalar and aggregate functions docs: switch completely to generated docs for scalar and aggregate functions Oct 29, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation development-process Related to development process of DataFusion labels Oct 29, 2024
@Omega359 Omega359 marked this pull request as ready for review October 29, 2024 14:16
Copy link
Contributor

@jonathanc-n jonathanc-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Omega359 This looks good, thank you!

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Omega359 -- I rendered stuff locally and it looks great
Screenshot 2024-10-29 at 2 37 14 PM

I'll file a new ticket to remove the last (Window Functions) page

@alamb alamb merged commit 223bb02 into apache:main Oct 29, 2024
25 of 26 checks passed
@alamb
Copy link
Contributor

alamb commented Oct 29, 2024

Filed #13171 for last bit

@alamb alamb mentioned this pull request Nov 5, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of DataFusion documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove old static documentation function pages (Aggregate/Scalar)
3 participants