Minor: Document how to test for trailing whitespace in slt / sqllogictests
#13215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
slt / sqllogictests
findepi
approved these changes
Nov 1, 2024
datafusion/sqllogictest/README.md
Outdated
| ``` | ||
|
|
||
| To test trailing whitespace, project additional non-whitespace column on the | ||
| right. For example, by selecting `'XX'` after the column of interest, the test |
There was a problem hiding this comment.
It's any non-whitespace, but we can take opportunity to suggest what we want to see in tests.
What about '|' that's used in one test i added, or '$' (not non-typical for marking end of line)?
There was a problem hiding this comment.
Let's use | to be consistent with what you added . I will update the PR
Co-authored-by: Piotr Findeisen <[email protected]>
github-actions
bot
removed
the
development-process
jonahgao
approved these changes
Nov 8, 2024
jayzhan211
pushed a commit
to jayzhan211/datafusion
that referenced
this pull request
Nov 12, 2024
…ictests (apache#13215) * Minor: Document how to test for trailing whitespace * Apply suggestions from code review Co-authored-by: Piotr Findeisen <[email protected]> * Use `|` for consistency --------- Co-authored-by: Piotr Findeisen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
@findepi figured out a good way to test for trailing spaces, let's put that in the user documentation as suggested by #13197 (comment)
What changes are included in this PR?
Add docs and slt examples
Are these changes tested?
Yes
Are there any user-facing changes?
docs and tests, no functional changes