Docs: Update dependencies in requirements.txt for python3.12
#13339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
AnthonyZhOon
changed the title
requirements.txt for python3.12requirements.txt for python3.12
|
While you're on it, you can also bump the docs CI Python version: datafusion/.github/workflows/docs.yaml Lines 26 to 29 in be19afc |
github-actions
bot
added
the
development-process
|
Could you rebase the PR? I think the CI failure is unrelated and was fixed by #13340, but I would like to see the CI passing before we merge this. |
|
Yep, synced my fork. Seems like it was unrelated to this PR |
crepererum
approved these changes
Nov 13, 2024
|
thank you |
alamb
pushed a commit
to alamb/datafusion
that referenced
this pull request
Nov 13, 2024
…e#13339) * Update requirements.txt for python3.12 * Update requirements.txt with a minimum version for `setuptools` * Bump to python 3.12 in docs CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #13337
Rationale for this change
PEP 632 - Deprecate distutils module has removed
distutilsfrom the standard library in python 3.12. Instead maintaining the module at thesetuptoolspackage.Updating the dependencies to reflect this allows the docs to be built with python 3.12 and should still work on earlier python versions.
What changes are included in this PR?
An extra dependency on
setuptoolsin the requirements.txt with a version constraint>=48.0.0whendistutilswas first available.Are these changes tested?
I have successfully built and viewed the docs with python3.12
Are there any user-facing changes?
There should be no user-facing changes and this is the recommended migration path in PEP 632 - Deprecate distutils module. Alternatives are mentioned in this stack overflow No module named 'distutils' in Python 3.12