Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix failures caused by array_prepend #13367

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

jonathanc-n
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

Added changes to array_prepend to fix the tests that are failing due to the changes in #13362

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 11, 2024
@jonathanc-n
Copy link
Contributor Author

jonathanc-n commented Nov 11, 2024

@alamb @Omega359 I believe this will probably keep happening from time to time (newer committers being unaware of the dynamic docs for UDFs). I'll open an issue to put this in the HOWTOs to make sure its more obvious despite it being mentioned in the docs (it doens't really stand out).

@Omega359
Copy link
Contributor

There is a big warning at the top of those files but adding notes to howto wouldn't hurt at all.

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jonathanc-n for fixing CI

@comphead comphead merged commit cadeb53 into apache:main Nov 12, 2024
26 checks passed
jayzhan211 pushed a commit to jayzhan211/datafusion that referenced this pull request Nov 12, 2024
alamb pushed a commit to alamb/datafusion that referenced this pull request Nov 13, 2024
@jonathanc-n jonathanc-n deleted the array-prepend branch November 17, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants