Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix documentation for null_string to array_to_string + string_to_array #13397

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

jonathanc-n
Copy link
Contributor

Which issue does this PR close?

Closes #13384.

Rationale for this change

What changes are included in this PR?

Added and fixed docs for array_to_string and string_to_array

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 13, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jonathanc-n

fn get_string_to_array_doc() -> &'static Documentation {
DOCUMENTATION.get_or_init(|| {
DOCUMENTATION_STRING_TO_ARRAY.get_or_init(|| {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find 👍

@alamb alamb changed the title fix: Add null_string to array_to_string + string_to_array fix: Fix documentation for null_string to array_to_string + string_to_array Nov 13, 2024
@jayzhan211
Copy link
Contributor

Nice, thanks @jonathanc-n @alamb

@jayzhan211 jayzhan211 merged commit 2d86725 into apache:main Nov 14, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: array_to_string missing 3rd 'null_string' argument in documentation
3 participants