refactor: use LazyLock in the user_doc macro
#13684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comphead
reviewed
Dec 7, 2024
datafusion/macros/src/lib.rs
Outdated
| Some(#lock_name.get_or_init(|| { | ||
| Documentation::builder(DocSection { include: #doc_section_include, label: #doc_section_lbl, description: #doc_section_description }, | ||
| fn doc(&self) -> Option<&datafusion_doc::Documentation> { | ||
| static DOCUMENTATION: std::sync::LazyLock<datafusion_doc::Documentation> = |
There was a problem hiding this comment.
thats interesting, I tried doing the same with OnceLock, to move it inside the doc method but it didn't work. Surprisingly it works with LazyLock
comphead
reviewed
Dec 7, 2024
|
Conflicting resolved. Thanks @comphead for the review. |
zhuliquan
pushed a commit
to zhuliquan/datafusion
that referenced
this pull request
Dec 11, 2024
* refactor: use `LazyLock` in the `user_doc` macro * Fix cargo doc * Update datafusion/macros/src/lib.rs * Fix doc comment --------- Co-authored-by: Oleks V <[email protected]>
zhuliquan
pushed a commit
to zhuliquan/datafusion
that referenced
this pull request
Dec 15, 2024
* refactor: use `LazyLock` in the `user_doc` macro * Fix cargo doc * Update datafusion/macros/src/lib.rs * Fix doc comment --------- Co-authored-by: Oleks V <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #11687
Rationale for this change
Replace
OnceLockwithLazyLock.What changes are included in this PR?
Are these changes tested?
Yes.
Run
./dev/update_function_docs.shand verified that the documentation content didn't changed.Are there any user-facing changes?
No