chore: clean up dependencies #13728
Merged
chore: clean up dependencies #13728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
development-process
|
If there are unused packages the clippy will fail |
findepi
reviewed
Dec 11, 2024
| @@ -34,5 +34,5 @@ runs: | |||
| echo "RUSTC_WRAPPER=sccache" >> $GITHUB_ENV | |||
| echo "SCCACHE_GHA_ENABLED=true" >> $GITHUB_ENV | |||
| echo "RUST_BACKTRACE=1" >> $GITHUB_ENV | |||
| echo "RUSTFLAGS=-C debuginfo=line-tables-only -C incremental=false" >> $GITHUB_ENV | |||
| echo "RUSTFLAGS=-C debuginfo=line-tables-only -C incremental=false -Wunused-crate-dependencies" >> $GITHUB_ENV | |||
There was a problem hiding this comment.
if this is global lint, it could be defined in cargo.toml in the lint section.
However, this is awesome for production code, but may be hard to do for tests/benchmark code.
At least in arrow-rs, i tried to enable this globally but failed.
see apache/arrow-rs#6804 (comment)
There was a problem hiding this comment.
going through the same. I'm keen to disable the lint for benches lets see where it can bring me
github-actions
bot
added
logical-expr
|
@findepi PTAL |
findepi
approved these changes
Dec 13, 2024
| serde_json = { workspace = true } | ||
| test-utils = { path = "../../test-utils" } | ||
| tokio = { workspace = true, features = ["rt-multi-thread", "parking_lot", "fs"] } | ||
| tokio-postgres = "0.7.7" |
|
So this ended up with no CI changes for now, right? It's a good change nonetheless. Just PR title may want a change. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #13726
Closes #.
Rationale for this change
Clean up dependencies
Going forward Im planning to add crate level hint
#![warn(unused_extern_crates)]to specific crates, cannot do that globally as we got a lot of false positives on crates having test/bench sub crates.What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?