Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[POC] Try to plan ast::Expr::CompoundFieldAccess syntax #13734

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

[POC] Try to plan ast::Expr::CompoundFieldAccess syntax #13734

wants to merge 9 commits into from

Conversation

goldmedal
Copy link
Contributor

Which issue does this PR close?

Related to apache/datafusion-sqlparser-rs#1551

Rationale for this change

This PR is based on #13546

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added sql SQL Planner logical-expr Logical plan and expressions core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) common Related to common crate labels Dec 11, 2024
@goldmedal goldmedal mentioned this pull request Dec 11, 2024
Open
@goldmedal
Copy link
Contributor Author

Occurred stack overflow when planning tpcds q64 in some os. 🤔 It passed in my local environments.

     Running tests\tpcds_planning.rs (target\debug\deps\tpcds_planning-b20526184f0a10d1.exe)

thread 'tpcds_logical_q64' has overflowed its stack

@findepi
Copy link
Member

findepi commented Dec 13, 2024

Is the code compiled with opt-level 1? AFAIU, otherwise all enums have insane (stack) size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
common Related to common crate core Core DataFusion crate logical-expr Logical plan and expressions sql SQL Planner sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goldmedal @findepi @alamb