Update to bigdecimal 0.4.7 #13747
Merged
Update to bigdecimal 0.4.7 #13747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add `decimal` to function name - drop `precision` parameter as it is not supposed to affect the result
Utilize new `to_plain_string` function
findepi
force-pushed
the
findepi/update-to-bigdecimal-0-4-7-c227e2
branch
from
c60bc81 to
0eb0ded
Compare
jonahgao
approved these changes
Dec 13, 2024
| @@ -149,19 +128,41 @@ mod tests { | |||
|
|
|||
| #[test] | |||
| fn test_big_decimal_to_str() { | |||
There was a problem hiding this comment.
Do we still need these tests if to_plain_string is reliable🤔
There was a problem hiding this comment.
maybe not, but this also tests for normalization if any, and this may be type dependent
this test and the tested helper were supposed to go away, see last commit in #13743. Hopefully this lands one day.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utilize new
to_plain_stringfunction (added in akubera/bigdecimal-rs#135)