Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate csv_opener.rs and json_opener.rs into a single example (#… #13981

Merged

Conversation

cj-zhukov
Copy link
Contributor

…13955)

Which issue does this PR close?

Closes #13955.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @cj-zhukov -- very nice 🙏

This looks like a step forward to me and is much better than what is on main.

I left some comment suggestions, but I don't think they are needed prior to merge -- we could do them as a follow on PR too

datafusion-examples/examples/csv_json_opener.rs Outdated Show resolved Hide resolved
datafusion-examples/README.md Outdated Show resolved Hide resolved
@cj-zhukov
Copy link
Contributor Author

@alamb Andrew, these are good comment suggestions. Let's add them as well.

@cj-zhukov
Copy link
Contributor Author

@alamb Andrew, I've noticed some checks have failed. Could you help me understand if this is related to my changes or something else? I'd be happy to address the issue.

@alamb
Copy link
Contributor

alamb commented Jan 4, 2025

@alamb Andrew, I've noticed some checks have failed. Could you help me understand if this is related to my changes or something else? I'd be happy to address the issue.

Hi @cj-zhukov

The output says what to do to fix the issue

Run # if you encounter error, rerun the command below and commit the changes
  # if you encounter error, rerun the command below and commit the changes
  #
  # ignore subproject CHANGELOG.md because they are machine generated
  npx prettier@[2](https://github.com/apache/datafusion/actions/runs/12583047937/job/35070117839?pr=13981#step:4:2).7.1 --write \
    '{datafusion,datafusion-cli,datafusion-examples,dev,docs}/**/*.md' \
    '!datafusion/CHANGELOG.md' \
    README.md \
    CONTRIBUTING.md
  git diff --exit-code
  shell: /usr/bin/bash -e {0}

Likewise the cargo fmt issue is related: https://github.com/apache/datafusion/actions/runs/12583047930/job/35070118199?pr=13981

I think you can fix it by running cargo fmt locally and checking in the result

for https://github.com/apache/arrow-rs/actions/runs/12603098777/job/35127463640?pr=6936 that does not look related to your chages. Perhaps you can merge up from main and see if they are fixed:

git fetch origin
git merge origin/main
git push

@jonahgao jonahgao merged commit 78ee13a into apache:main Jan 5, 2025
25 checks passed
@cj-zhukov cj-zhukov deleted the cj-zhukov/consolidate-csv-json-opener branch January 5, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate csv_opener.rs and json_opener.rs into a single example
3 participants