-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate csv_opener.rs and json_opener.rs into a single example (#… #13981
Consolidate csv_opener.rs and json_opener.rs into a single example (#… #13981
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @cj-zhukov -- very nice 🙏
This looks like a step forward to me and is much better than what is on main.
I left some comment suggestions, but I don't think they are needed prior to merge -- we could do them as a follow on PR too
Co-authored-by: Andrew Lamb <[email protected]>
Co-authored-by: Andrew Lamb <[email protected]>
@alamb Andrew, these are good comment suggestions. Let's add them as well. |
@alamb Andrew, I've noticed some checks have failed. Could you help me understand if this is related to my changes or something else? I'd be happy to address the issue. |
Hi @cj-zhukov
The output says what to do to fix the issue
Likewise the cargo fmt issue is related: https://github.com/apache/datafusion/actions/runs/12583047930/job/35070118199?pr=13981 I think you can fix it by running for https://github.com/apache/arrow-rs/actions/runs/12603098777/job/35127463640?pr=6936 that does not look related to your chages. Perhaps you can merge up from main and see if they are fixed: git fetch origin
git merge origin/main
git push |
…13955)
Which issue does this PR close?
Closes #13955.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?