Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: update wasm-supported crates, add tests #14005

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Conversation

Lordworms
Copy link
Contributor

Which issue does this PR close?

part of #7652

Closes #.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Lordworms -- this looks great

Perhaps @waynexia or @XiangpengHao have some other thoughts as they have worked on wasm recently as well

@@ -124,4 +132,48 @@ mod test {
let task_ctx = session_context.task_ctx();
let _ = collect(physical_plan, task_ctx).await.unwrap();
}

#[wasm_bindgen_test(unsupported = tokio::test)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@alamb alamb changed the title Chore: update wasm-supported crates Chore: update wasm-supported crates, add tests Jan 4, 2025
@alamb alamb merged commit 2848aaf into apache:main Jan 6, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants