FIX : Incorrect NULL handling in BETWEEN expression

[getChan]

Which issue does this PR close?

Closes #13976.

Rationale for this change

What changes are included in this PR?

in BETWEEN expression,
The type of the high value is determined by the type of the high value, not the type of the low value.

As a result, the coercion type in a BETWEEN expression is determined by comparing the low, high, and compare values.

datafusion/datafusion/optimizer/src/analyzer/type_coercion.rs

Lines 420 to 441 in a2a353b

	let expr_type = expr.get_type(self.schema)?;
	let low_type = low.get_type(self.schema)?;
	let low_coerced_type = comparison_coercion(&expr_type, &low_type)
	.ok_or_else(|| {
	DataFusionError::Internal(format!(
	"Failed to coerce types {expr_type} and {low_type} in BETWEEN expression"
	))
	})?;
	let high_type = high.get_type(self.schema)?;
	let high_coerced_type = comparison_coercion(&expr_type, &high_type)
	.ok_or_else(|| {
	DataFusionError::Internal(format!(
	"Failed to coerce types {expr_type} and {high_type} in BETWEEN expression"
	))
	})?;
	let coercion_type =
	comparison_coercion(&low_coerced_type, &high_coerced_type)
	.ok_or_else(|| {
	DataFusionError::Internal(format!(
	"Failed to coerce types {expr_type} and {high_type} in BETWEEN expression"
	))
	})?;

Are these changes tested?

unit tested, sqllogic tested.

Are there any user-facing changes?

in BETWEEN expression,
Type coercion will work as intended.

[alamb]

Thanks @getChan -- this is a nice fix ❤️

Thanks to @2010YOUY01 for filing the ticket.

[alamb]

🤦 -- nice fix

[alamb]

Would it be possible to move this file into this https://github.com/apache/datafusion/tree/main/datafusion/sqllogictest/test_files/expr directory?

We can do it as a follow on PR too

[getChan]

thanks. moved it.

[alamb]

Thanks again @getChan 🚀