Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for Decimal128 and Decimal256 types in interval arithmetic #14126

Merged
merged 8 commits into from
Jan 25, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update ut
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
  • Loading branch information
waynexia committed Jan 23, 2025
commit e0768e68ece6d9d9976ac3d170db3d480de33a0d
5 changes: 4 additions & 1 deletion datafusion/expr-common/src/interval_arithmetic.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3903,7 +3903,10 @@ mod tests {
let result = handle_overflow::<true>(&dt, op, &lhs, &rhs);
assert_eq!(result, ScalarValue::Decimal128(None, 38, 35));
let result = handle_overflow::<false>(&dt, op, &lhs, &rhs);
assert_eq!(result, ScalarValue::Decimal128(Some(i128::MAX), 38, 35));
assert_eq!(
result,
ScalarValue::Decimal128(Some(99999999999999999999999999999999999999), 38, 35)
);

Ok(())
}
Expand Down
Loading