Make parquet support optional for datafusion-common crate #1886
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Hi! This is a small PR that makes the
parquet
dependency of the newdatafusion-common
crate optional. The motivation is that I'd like to depend ondatafusion-common
in the WebAssembly logic of VegaFusion, and the parquet dependency is the only thing preventingdatafusion-common
from compiling to WASM.What changes are included in this PR?
The
parquet
dependency indatafusion-common
has been marked asoptional
, and feature gates are used in theerror.rs
file (following the pattern of the optionalavro
dependency). This feature is then enabled by thedatafusion
crate.Are there any user-facing changes?
No