Minor/Doc: Add DataFrame::write_table to DataFrame user guide #8527
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comphead
reviewed
Dec 13, 2023
| @@ -95,6 +95,7 @@ These methods execute the logical plan represented by the DataFrame and either c | |||
| | write_csv | Execute this DataFrame and write the results to disk in CSV format. | | |||
| | write_json | Execute this DataFrame and write the results to disk in JSON format. | | |||
| | write_parquet | Execute this DataFrame and write the results to disk in Parquet format. | | |||
| | write_table | Execute this DataFrame and write the results via the insert_into method of the registered TableProvider | | |||
There was a problem hiding this comment.
lgtm @devinjdangelo
But I also just realized we dont have write_parquet covered with tests. Creating a followup
There was a problem hiding this comment.
Followup PR open for this as well #8531
comphead
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
none
Rationale for this change
The user guide contains a table describing the methods/actions available for DataFrames but currently does not mention write_table.
What changes are included in this PR?
Add write_table to available actions in DataFrame user guide.
Are these changes tested?
Via existing tests
Are there any user-facing changes?
Doc update