Remove unbounded_input from FileSinkOptions #8605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinjdangelo
force-pushed
the
remove_unbounded_listing_table
branch
from
68eed86 to
740d427
Compare
devinjdangelo
commented
Dec 20, 2023
datafusion/proto/gen/src/main.rs
Outdated
| @@ -28,6 +28,7 @@ fn main() -> Result<(), String> { | |||
| let descriptor_path = proto_dir.join("proto_descriptor.bin"); | |||
|
|
|||
| prost_build::Config::new() | |||
| .protoc_arg("--experimental_allow_proto3_optional") | |||
There was a problem hiding this comment.
Should be able to remove this after #8602 is fixed
There was a problem hiding this comment.
Removed merged main, and confirmed that 8602 is fixed for me as well
7 tasks
alamb
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
Thank you (again) @devinjdangelo
@metesynnada / @ozankabak can you please also review this PR to make sure we are not removing something that is important for your usecase?
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None, but related to #8604
Rationale for this change
Now that writing unbounded (streaming) sources is supported via
StreamWrite, otherDataSinkimpls do not need to worry about yielding on unbounded input plans.What changes are included in this PR?
Removes unbounded_input checks in FileSinkConfig
Are these changes tested?
Yes, by existing tests
Are there any user-facing changes?
No