WIP: Support Proto Serialization of Advanced parquet::WriterProperties Options #8670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andygrove I started working on this but hit a roadblock, as the parquet crate does not expose default_column_properties. We could open an upstream ticket to expose this, but I am also wondering if it might be better overall to just refactor the Copy logical plan to never contain FileTypeWriterOptions. The reason that was added was to provide a nicer interface for DataFrame methods than tuples of strings. We may be able to rework that interface to avoid needing to serialize these complex arrow-rs writer structs. |
|
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8632
Rationale for this change
Downstream systems such as Ballista can only support WriterProperties options if they are proto serializable.
What changes are included in this PR?
Add additional WriterProperties to datafusion.proto
Are these changes tested?
Tests not yet updated
Are there any user-facing changes?
No